lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Jan 2020 03:00:45 -0500 From: "Theodore Y. Ts'o" <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: "zhangyi (F)" <yi.zhang@...wei.com>, linux-ext4@...r.kernel.org, jack@...e.com, adilger.kernel@...ger.ca, liangyun2@...wei.com, luoshijie1@...wei.com Subject: Re: [PATCH v3 3/4] jbd2: make sure ESHUTDOWN to be recorded in the journal superblock On Wed, Dec 04, 2019 at 06:05:28PM +0100, Jan Kara wrote: > On Wed 04-12-19 20:46:13, zhangyi (F) wrote: > > Commit fb7c02445c49 ("ext4: pass -ESHUTDOWN code to jbd2 layer") want > > to allow jbd2 layer to distinguish shutdown journal abort from other > > error cases. So the ESHUTDOWN should be taken precedence over any other > > errno which has already been recoded after EXT4_FLAGS_SHUTDOWN is set, > > but it only update errno in the journal suoerblock now if the old errno > > is 0. > > > > Fixes: fb7c02445c49 ("ext4: pass -ESHUTDOWN code to jbd2 layer") > > Signed-off-by: zhangyi (F) <yi.zhang@...wei.com> > > Yeah, I think this is correct if I understand the logic correctly but I'd > like Ted to have a look at this. Anyway, feel free to add: > > Reviewed-by: Jan Kara <jack@...e.cz> Yep, this looks sane. Thanks, applied. - Ted
Powered by blists - more mailing lists