lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Feb 2020 15:49:52 +0530 From: Ritesh Harjani <riteshh@...ux.ibm.com> To: yangerkun <yangerkun@...wei.com>, tytso@....edu, jack@...e.com Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: using matching invalidatepage in ext4_writepage On 2/26/20 9:40 AM, yangerkun wrote: > Run generic/388 with journal data mode sometimes may trigger the warning > in ext4_invalidatepage. Actually, we should use the matching invalidatepage > in ext4_writepage. > > Signed-off-by: yangerkun <yangerkun@...wei.com> generic/388 still fails, but the patch makes sense to me and also avoids kernel warning. Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com> > --- > fs/ext4/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index fa0ff78dc033..78e805d42ada 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -1974,7 +1974,7 @@ static int ext4_writepage(struct page *page, > bool keep_towrite = false; > > if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) { > - ext4_invalidatepage(page, 0, PAGE_SIZE); > + inode->i_mapping->a_ops->invalidatepage(page, 0, PAGE_SIZE); > unlock_page(page); > return -EIO; > } >
Powered by blists - more mailing lists