linux-ext4 - Re: [PATCH] ext4: using matching invalidatepage in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200226120308.GI10728@quack2.suse.cz>
Date:   Wed, 26 Feb 2020 13:03:08 +0100
From:   Jan Kara <jack@...e.cz>
To:     yangerkun <yangerkun@...wei.com>
Cc:     tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: using matching invalidatepage in ext4_writepage

On Wed 26-02-20 12:10:02, yangerkun wrote:
> Run generic/388 with journal data mode sometimes may trigger the warning
> in ext4_invalidatepage. Actually, we should use the matching invalidatepage
> in ext4_writepage.
> 
> Signed-off-by: yangerkun <yangerkun@...wei.com>

Thanks for the patch! It looks good to me. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fa0ff78dc033..78e805d42ada 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -1974,7 +1974,7 @@ static int ext4_writepage(struct page *page,
>  	bool keep_towrite = false;
>  
>  	if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) {
> -		ext4_invalidatepage(page, 0, PAGE_SIZE);
> +		inode->i_mapping->a_ops->invalidatepage(page, 0, PAGE_SIZE);
>  		unlock_page(page);
>  		return -EIO;
>  	}
> -- 
> 2.23.0.rc2.8.gff66981f45
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR