lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 26 Feb 2020 21:24:32 -0800
Cc:     Ira Weiny <>,
        Dave Chinner <>, Jan Kara <>,
        Alexander Viro <>,
        "Darrick J. Wong" <>,
        Dan Williams <>,
        Dave Chinner <>,
        Christoph Hellwig <>,
        "Theodore Y. Ts'o" <>,,,
Subject: [PATCH V5 02/12] fs: Remove unneeded IS_DAX() check

From: Ira Weiny <>

Remove the check because DAX now has it's own read/write methods and
file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on
their own.  Therefore, it does not matter if the file state is DAX when
the iocb flags are created.

Reviewed-by: Dave Chinner <>
Reviewed-by: Jan Kara <>
Signed-off-by: Ira Weiny <>

Changes from v3:
	Reword commit message.
	Reordered to be a 'pre-cleanup' patch
 include/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 3cd4fe6b845e..63d1e533a07d 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3388,7 +3388,7 @@ extern int file_update_time(struct file *file);
 static inline bool io_is_direct(struct file *filp)
-	return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host);
+	return (filp->f_flags & O_DIRECT);
 static inline bool vma_is_dax(struct vm_area_struct *vma)

Powered by blists - more mailing lists