linux-ext4 - Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428164808.GA3632@infradead.org>
Date:   Tue, 28 Apr 2020 09:48:08 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, dhowells@...hat.com,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4_msg()

On Tue, Apr 28, 2020 at 06:45:24PM +0200, Lukas Czerner wrote:
> At the parsing phase of mount in the new mount api sb will not be
> available so allow sb to be NULL in ext4_msg and use that in
> handle_mount_opt().
> 
> Also change return value to appropriate -EINVAL where needed.

Shouldn't mount-time messages be reported using the logfc and family
helpers from include/linux/fs_context.h? (which btw, have really
horrible over-generic names).