linux-ext4 - Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428165747.ondq7nbn4ol3j3lu@work>
Date:   Tue, 28 Apr 2020 18:57:47 +0200
From:   Lukas Czerner <lczerner@...hat.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-ext4@...r.kernel.org, dhowells@...hat.com,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4_msg()

On Tue, Apr 28, 2020 at 09:48:08AM -0700, Christoph Hellwig wrote:
> On Tue, Apr 28, 2020 at 06:45:24PM +0200, Lukas Czerner wrote:
> > At the parsing phase of mount in the new mount api sb will not be
> > available so allow sb to be NULL in ext4_msg and use that in
> > handle_mount_opt().
> > 
> > Also change return value to appropriate -EINVAL where needed.
> 
> Shouldn't mount-time messages be reported using the logfc and family
> helpers from include/linux/fs_context.h? (which btw, have really
> horrible over-generic names).

I am sure it should at some point, but I am not really sure how ready
it is at the moment. Last time I checked David told me not to bother
using it yet.

Is it ready yet David ? Should we be switching to it ?

-Lukas