linux-ext4 - Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7f22961-2fb2-d69a-28cc-073b735c6907@jguk.org>
Date:   Sun, 17 May 2020 23:39:19 +0100
From:   Jonny Grant <jg@...k.org>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2



On 11/05/2020 21:19, Andreas Dilger wrote:
> On May 8, 2020, at 2:36 PM, Jonny Grant <jg@...k.org> wrote:
>>
>> Please find attached patch for review.
>>
>> 2020-05-08  Jonny Grant  <jg@...k.org>
>>
>> 	tests: comment ext4_dir_entry_2 file_type member
>>
>> Cheers, Jonny
>> <ext4_ext4_dir_entry_2.patch>
> 
> Hi Jonny,
> thanks for your patch.  The patch itself looks reasonable, but can
> you please submit it as inline text next time.  To avoid issues with
> whitespace formatting, you can use "git send-email" directly from
> the command-line after making a commit with this change in it.
> 
> Also, the subject line of the patch should just have "ext4:" as the
> subsystem, you don't need the whole pathname for the file, like:
> 
>      ext4: add comment for ext4_dir_entry_2 file_type member
> 
> Finally, you should add a line:
> 
>      Signed-off-by: Jonny Grant <jg@...k.org>
> 
> to indicate that you wrote the patch and you are OK with others using it.
> 
> See Documentation/process/submitting-patches.rst for full details.
> 
> Cheers, Andreas


Many thanks for your reply Andreas. I will follow your that patch guide, 
thank you for the link.

Could I check, did you submit, or shall I submit via git send-email ?


Many thanks
Jonny