lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 17 May 2020 22:01:22 -0600
From:   Andreas Dilger <>
To:     Jonny Grant <>
Cc:     Ext4 Developers List <>
Subject: Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2

On May 17, 2020, at 4:39 PM, Jonny Grant <> wrote:
> On 11/05/2020 21:19, Andreas Dilger wrote:
>> On May 8, 2020, at 2:36 PM, Jonny Grant <> wrote:
>>> Please find attached patch for review.
>>> 2020-05-08  Jonny Grant  <>
>>> 	tests: comment ext4_dir_entry_2 file_type member
>>> Cheers, Jonny
>> Hi Jonny,
>> thanks for your patch.  The patch itself looks reasonable, but can
>> you please submit it as inline text next time.  To avoid issues with
>> whitespace formatting, you can use "git send-email" directly from
>> the command-line after making a commit with this change in it.
>> Also, the subject line of the patch should just have "ext4:" as the
>> subsystem, you don't need the whole pathname for the file, like:
>>     ext4: add comment for ext4_dir_entry_2 file_type member
>> Finally, you should add a line:
>>     Signed-off-by: Jonny Grant <>
>> to indicate that you wrote the patch and you are OK with others using it.
>> See Documentation/process/submitting-patches.rst for full details.
>> Cheers, Andreas
> Many thanks for your reply Andreas. I will follow your that patch guide, thank you for the link.
> Could I check, did you submit, or shall I submit via git send-email ?

I didn't submit it.  Best if you do so with the appropriate changes.

Cheers, Andreas

Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)

Powered by blists - more mailing lists