linux-ext4 - RWF_NOWAIT writes not failing when writing to a range with holes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jun 2020 18:53:11 +0100
From:   Filipe Manana <fdmanana@...il.com>
To:     linux-ext4 <linux-ext4@...r.kernel.org>
Subject: RWF_NOWAIT writes not failing when writing to a range with holes

Hi,

I found out a bug in btrfs where a RWF_NOWRITE does not fail if we
write to a range that starts with an extent followed by holes (since
it requires allocating extent(s)).

When writing a test case for fstests I noticed xfs fails with -EAGAIN
as expected, but ext4 succeeds just like btrfs currently does:

mkfs.ext4 -F /dev/sdb
mount /dev/sdb /mnt

xfs_io -f -d -c "pwrite -S 0xab -b 256K 0 256K" /mnt/bar
xfs_io -c "fpunch 64K 64K" /mnt/bar
sync
xfs_io -d -c "pwrite -N -V 1 -b 128K -S 0xfe 0 128K" /mnt/bar

Is this a known bug? Or is there a technical reason that makes it too
expensive to check no extents will need to be allocated?

Thanks.

-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”