linux-ext4 - ext4: delete the invalid BUGON in ext4_mb_load_buddy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad68e8a2-5ec3-5beb-537f-f3e53f55367a@gmail.com>
Date:   Mon, 27 Jul 2020 09:54:14 +0800
From:   brookxu <brookxu.cn@...il.com>
To:     tytso@....edu, adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()

Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
code has already judged whether page is NULL.

Signed-off-by: Chunguang Xu <brookxu@...cent.com>
---
 fs/ext4/mballoc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 28a139f..9b1c3ad 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1279,9 +1279,6 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group, gfp_t gfp)
     e4b->bd_buddy_page = page;
     e4b->bd_buddy = page_address(page) + (poff * sb->s_blocksize);
 
-    BUG_ON(e4b->bd_bitmap_page == NULL);
-    BUG_ON(e4b->bd_buddy_page == NULL);
-
     return 0;
 
 err:
-- 
1.8.3.1