linux-ext4 - Re: ext4: delete the invalid BUGON in ext4_mb_load_buddy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200727032011.CDE084204B@d06av24.portsmouth.uk.ibm.com>
Date:   Mon, 27 Jul 2020 08:50:11 +0530
From:   Ritesh Harjani <riteshh@...ux.ibm.com>
To:     brookxu <brookxu.cn@...il.com>, tytso@....edu,
        adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()



On 7/27/20 7:24 AM, brookxu wrote:
> Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
> code has already judged whether page is NULL.
> 
> Signed-off-by: Chunguang Xu <brookxu@...cent.com>

Thanks for the patch. LGTM. Feel free to add.
Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>

> ---
>   fs/ext4/mballoc.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 28a139f..9b1c3ad 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1279,9 +1279,6 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group, gfp_t gfp)
>       e4b->bd_buddy_page = page;
>       e4b->bd_buddy = page_address(page) + (poff * sb->s_blocksize);
>   
> -    BUG_ON(e4b->bd_bitmap_page == NULL);
> -    BUG_ON(e4b->bd_buddy_page == NULL);
> -
>       return 0;
>   
>   err:
>