linux-ext4 - Re: [PATCH 3/6] ext4: Check journal inode extents more carefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jul 2020 17:10:28 +0800
From:   luomeng <luomeng12@...wei.com>
To:     Jan Kara <jack@...e.cz>, Ted Tso <tytso@....edu>
CC:     <linux-ext4@...r.kernel.org>, Lukas Czerner <lczerner@...hat.com>
Subject: Re: [PATCH 3/6] ext4: Check journal inode extents more carefully



在 2020/7/27 19:44, Jan Kara 写道:
> -int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk,
> +int ext4_inode_block_valid(struct inode *inode, ext4_fsblk_t start_blk,
>   			  unsigned int count)
>   {
>   	struct ext4_system_blocks *system_blks;
> @@ -344,8 +346,8 @@ int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk,
>   	 */
>   	rcu_read_lock();
>   	system_blks = rcu_dereference(sbi->system_blks);
Because of a change in the function parameters，there is no 'sbi' 
declared. So there will be a compile error:

   fs/ext4/block_validity.c: In function ‘ext4_inode_block_valid’:
   fs/ext4/block_validity.c:345:32: error: ‘sbi’ undeclared (first use 
        in this function)
   system_blks = rcu_dereference(sbi->system_blks);
> -	ret = ext4_data_block_valid_rcu(sbi, system_blks, start_blk,
> -					count);
> +	ret = ext4_data_block_valid_rcu(EXT4_SB(inode->i_sb), system_blks,
> +					start_blk, count, inode->i_ino);
>   	rcu_read_unlock();
>   	return ret;
>   }