lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Jul 2020 14:56:42 +0200 From: Jan Kara <jack@...e.cz> To: luomeng <luomeng12@...wei.com> Cc: Jan Kara <jack@...e.cz>, Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org, Lukas Czerner <lczerner@...hat.com> Subject: Re: [PATCH 3/6] ext4: Check journal inode extents more carefully On Tue 28-07-20 17:10:28, luomeng wrote: > 在 2020/7/27 19:44, Jan Kara 写道: > > -int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk, > > +int ext4_inode_block_valid(struct inode *inode, ext4_fsblk_t start_blk, > > unsigned int count) > > { > > struct ext4_system_blocks *system_blks; > > @@ -344,8 +346,8 @@ int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk, > > */ > > rcu_read_lock(); > > system_blks = rcu_dereference(sbi->system_blks); > Because of a change in the function parameters,there is no 'sbi' declared. > So there will be a compile error: > > fs/ext4/block_validity.c: In function ‘ext4_inode_block_valid’: > fs/ext4/block_validity.c:345:32: error: ‘sbi’ undeclared (first use > in this function) > system_blks = rcu_dereference(sbi->system_blks); Hum, right. It gets fixed up in the following patch but since this patch is marked for stable, we better fix it. Thanks for noticing! Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists