linux-ext4 - Re: [PATCH 0/2] Fix race between do_invalidatepage and init_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200824155143.GH24877@quack2.suse.cz>
Date:   Mon, 24 Aug 2020 17:51:43 +0200
From:   Jan Kara <jack@...e.cz>
To:     Ye Bin <yebin10@...wei.com>
Cc:     jack@...e.com, tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 0/2] Fix race between do_invalidatepage and
 init_page_buffers

Hello,

On Sat 22-08-20 16:22:16, Ye Bin wrote:
> Ye Bin (2):
>   ext4: Add comment to BUFFER_FLAGS_DISCARD for search code
>   jbd2: Fix race between do_invalidatepage and init_page_buffers
> 
>  fs/buffer.c                 | 12 +++++++++++-
>  fs/jbd2/journal.c           |  7 +++++++
>  include/linux/buffer_head.h |  2 ++
>  3 files changed, 20 insertions(+), 1 deletion(-)

Thanks for the good description of the problem and the analysis. I could
now easily understand what was really happening on your system. I think the
problem should be fixed differently through - it is a problem of
block_write_full_page() that it invalidates buffers while JBD2 is working
with them. Attached patch should also fix the problem. Can you please test
whether it fixes your testcase as well? Thanks!

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR

View attachment "0001-fs-Don-t-invalidate-page-buffers-in-block_write_full.patch" of type "text/x-patch" (3893 bytes)