[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200826130753.GC15126@quack2.suse.cz>
Date: Wed, 26 Aug 2020 15:07:53 +0200
From: Jan Kara <jack@...e.cz>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-fsdevel@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
Andreas Dilger <adilger.kernel@...ger.ca>,
linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: delete duplicated words + other fixes
On Tue 04-08-20 19:48:50, Randy Dunlap wrote:
> Delete repeated words in fs/ext4/.
> {the, this, of, we, after}
>
> Also change spelling of "xttr" in inline.c to "xattr" in 2 places.
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> To: linux-fsdevel@...r.kernel.org
> Cc: "Theodore Ts'o" <tytso@....edu>
> Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> Cc: linux-ext4@...r.kernel.org
The patch looks good to me. You can add:
Reviewed-by: Jan Kara <jack@...e.cz>
Ted, I think this patch fell through the cracks while you were busy...
Honza
> ---
> fs/ext4/extents.c | 2 +-
> fs/ext4/indirect.c | 2 +-
> fs/ext4/inline.c | 4 ++--
> fs/ext4/inode.c | 2 +-
> fs/ext4/mballoc.c | 4 ++--
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> --- linux-next-20200804.orig/fs/ext4/extents.c
> +++ linux-next-20200804/fs/ext4/extents.c
> @@ -4029,7 +4029,7 @@ static int get_implied_cluster_alloc(str
> * down_read(&EXT4_I(inode)->i_data_sem) if not allocating file system block
> * (ie, create is zero). Otherwise down_write(&EXT4_I(inode)->i_data_sem)
> *
> - * return > 0, number of of blocks already mapped/allocated
> + * return > 0, number of blocks already mapped/allocated
> * if create == 0 and these are pre-allocated blocks
> * buffer head is unmapped
> * otherwise blocks are mapped
> --- linux-next-20200804.orig/fs/ext4/indirect.c
> +++ linux-next-20200804/fs/ext4/indirect.c
> @@ -1035,7 +1035,7 @@ static void ext4_free_branches(handle_t
> brelse(bh);
>
> /*
> - * Everything below this this pointer has been
> + * Everything below this pointer has been
> * released. Now let this top-of-subtree go.
> *
> * We want the freeing of this indirect block to be
> --- linux-next-20200804.orig/fs/ext4/inline.c
> +++ linux-next-20200804/fs/ext4/inline.c
> @@ -276,7 +276,7 @@ static int ext4_create_inline_data(handl
> len = 0;
> }
>
> - /* Insert the the xttr entry. */
> + /* Insert the xattr entry. */
> i.value = value;
> i.value_len = len;
>
> @@ -354,7 +354,7 @@ static int ext4_update_inline_data(handl
> if (error)
> goto out;
>
> - /* Update the xttr entry. */
> + /* Update the xattr entry. */
> i.value = value;
> i.value_len = len;
>
> --- linux-next-20200804.orig/fs/ext4/inode.c
> +++ linux-next-20200804/fs/ext4/inode.c
> @@ -2786,7 +2786,7 @@ retry:
> * ext4_journal_stop() can wait for transaction commit
> * to finish which may depend on writeback of pages to
> * complete or on page lock to be released. In that
> - * case, we have to wait until after after we have
> + * case, we have to wait until after we have
> * submitted all the IO, released page locks we hold,
> * and dropped io_end reference (for extent conversion
> * to be able to complete) before stopping the handle.
> --- linux-next-20200804.orig/fs/ext4/mballoc.c
> +++ linux-next-20200804/fs/ext4/mballoc.c
> @@ -124,7 +124,7 @@
> * /sys/fs/ext4/<partition>/mb_group_prealloc. The value is represented in
> * terms of number of blocks. If we have mounted the file system with -O
> * stripe=<value> option the group prealloc request is normalized to the
> - * the smallest multiple of the stripe value (sbi->s_stripe) which is
> + * smallest multiple of the stripe value (sbi->s_stripe) which is
> * greater than the default mb_group_prealloc.
> *
> * The regular allocator (using the buddy cache) supports a few tunables.
> @@ -2026,7 +2026,7 @@ void ext4_mb_complex_scan_group(struct e
> /*
> * IF we have corrupt bitmap, we won't find any
> * free blocks even though group info says we
> - * we have free blocks
> + * have free blocks
> */
> ext4_grp_locked_error(sb, e4b->bd_group, 0, 0,
> "%d free clusters as per "
--
Jan Kara <jack@...e.com>
SUSE Labs, CR
Powered by blists - more mailing lists