linux-ext4 - [ext4:dev 10/44] fs/jbd2/recovery.c:258:6: warning: variable 'seq' is uninitialized when used here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202010091737.hajyydHD-lkp@intel.com>
Date:   Fri, 9 Oct 2020 17:10:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Harshad Shirwadkar <harshadshirwadkar@...il.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu>
Subject: [ext4:dev 10/44] fs/jbd2/recovery.c:258:6: warning: variable 'seq'
 is uninitialized when used here

Hi Harshad,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
head:   ab7b179af3f98772f2433ddc4ace6b7924a4e862
commit: 23386fc5c4ce13c9be9a185e20f78dab355b17df [10/44] jbd2: fast commit recovery path
config: x86_64-randconfig-a004-20201009 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4cfc4025cc1433ca5ef1c526053fc9c4bfe64109)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?id=23386fc5c4ce13c9be9a185e20f78dab355b17df
        git remote add ext4 https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
        git fetch --no-tags ext4 dev
        git checkout 23386fc5c4ce13c9be9a185e20f78dab355b17df
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/jbd2/recovery.c:258:6: warning: variable 'seq' is uninitialized when used here [-Wuninitialized]
                             seq);
                             ^~~
   include/linux/jbd2.h:62:59: note: expanded from macro 'jbd_debug'
           __jbd2_debug((n), __FILE__, __func__, __LINE__, (fmt), ##a)
                                                                    ^
   fs/jbd2/recovery.c:241:18: note: initialize the variable 'seq' to silence this warning
           unsigned int seq;
                           ^
                            = 0
   1 warning generated.

vim +/seq +258 fs/jbd2/recovery.c

   234	
   235	static int fc_do_one_pass(journal_t *journal,
   236				  struct recovery_info *info, enum passtype pass)
   237	{
   238		unsigned int expected_commit_id = info->end_transaction;
   239		unsigned long next_fc_block;
   240		struct buffer_head *bh;
   241		unsigned int seq;
   242		int err = 0;
   243	
   244		next_fc_block = journal->j_first_fc;
   245		if (!journal->j_fc_replay_callback)
   246			return 0;
   247	
   248		while (next_fc_block <= journal->j_last_fc) {
   249			jbd_debug(3, "Fast commit replay: next block %ld",
   250				  next_fc_block);
   251			err = jread(&bh, journal, next_fc_block);
   252			if (err) {
   253				jbd_debug(3, "Fast commit replay: read error");
   254				break;
   255			}
   256	
   257			jbd_debug(3, "Processing fast commit blk with seq %d",
 > 258				  seq);
   259			err = journal->j_fc_replay_callback(journal, bh, pass,
   260						next_fc_block - journal->j_first_fc,
   261						expected_commit_id);
   262			next_fc_block++;
   263			if (err < 0 || err == JBD2_FC_REPLAY_STOP)
   264				break;
   265			err = 0;
   266		}
   267	
   268		if (err)
   269			jbd_debug(3, "Fast commit replay failed, err = %d\n", err);
   270	
   271		return err;
   272	}
   273	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35031 bytes)