lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Oct 2020 12:18:23 +0200 From: Sedat Dilek <sedat.dilek@...il.com> To: Ritesh Harjani <riteshh@...ux.ibm.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, tytso@....edu, jack@...e.cz, anju@...ux.vnet.ibm.com, "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com> Subject: Re: [PATCH 1/1] ext4: Fix bs < ps issue reported with dioread_nolock mount opt On Fri, Oct 9, 2020 at 9:19 AM Ritesh Harjani <riteshh@...ux.ibm.com> wrote: > > > > On 10/9/20 12:16 PM, Sedat Dilek wrote: > > On Thu, Oct 8, 2020 at 5:56 PM Ritesh Harjani <riteshh@...ux.ibm.com> wrote: > >> > >> left shifting m_lblk by blkbits was causing value overflow and hence > >> it was not able to convert unwritten to written extent. > >> So, make sure we typecast it to loff_t before do left shift operation. > >> Also in func ext4_convert_unwritten_io_end_vec(), make sure to initialize > >> ret variable to avoid accidentally returning an uninitialized ret. > >> > >> This patch fixes the issue reported in ext4 for bs < ps with > >> dioread_nolock mount option. > >> > >> Fixes: c8cc88163f40df39e50c ("ext4: Add support for blocksize < pagesize in dioread_nolock") > > > > Fixes: tag should be 12 digits (see [1]). > > ( Seen while walking through ext-dev Git commits. ) > > > Thanks Sedat, I guess it should be minimum 12 chars [1] > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n177 > OK. In my ~/.gitconfig: [core] abbrev = 12 # Check for 'Fixes:' tag used in the Linux-kernel development process (Thanks Kalle Valo). # Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst # Usage: $ git log --format=fixes | head -5 [pretty] fixes = Fixes: %h (\"%s\") Hope this is useful for others. - Sedat -
Powered by blists - more mailing lists