linux-ext4 - Re: [PATCH v2] ext4: Detect already used quota file early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201015145616.GE181507@mit.edu>
Date:   Thu, 15 Oct 2020 10:56:16 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org, Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH v2] ext4: Detect already used quota file early

On Thu, Oct 15, 2020 at 01:03:30PM +0200, Jan Kara wrote:
> When we try to use file already used as a quota file again (for the same
> or different quota type), strange things can happen. At the very least
> lockdep annotations may be wrong but also inode flags may be wrongly set
> / reset. When the file is used for two quota types at once we can even
> corrupt the file and likely crash the kernel. Catch all these cases by
> checking whether passed file is already used as quota file and bail
> early in that case.
> 
> This fixes occasional generic/219 failure due to lockdep complaint.
> 
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> Reported-by: Ritesh Harjani <riteshh@...ux.ibm.com>
> Signed-off-by: Jan Kara <jack@...e.cz>

Replied to the wrong patch previously.  Thanks, applied.

	       	     	   		- Ted