linux-ext4 - Re: [PATCH 3/8] ext4: use do_div() to calculate block offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 17 Oct 2020 10:23:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chunguang Xu <brookxu.cn@...il.com>, tytso@....edu,
        adilger.kernel@...ger.ca
Cc:     kbuild-all@...ts.01.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/8] ext4: use do_div() to calculate block offset

Hi Chunguang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.9]
[also build test ERROR on next-20201016]
[cannot apply to ext4/dev tytso-fscrypt/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chunguang-Xu/ext4-use-ASSERT-to-replace-J_ASSERT/20201016-115723
base:    bbf5c979011a099af5dc76498918ed7df445635b
config: arm-cerfcube_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1bcce45cce439ec86a89aa8cfc895b5e9ad5046b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chunguang-Xu/ext4-use-ASSERT-to-replace-J_ASSERT/20201016-115723
        git checkout 1bcce45cce439ec86a89aa8cfc895b5e9ad5046b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/math64.h:7,
                    from include/linux/time.h:6,
                    from fs/ext4/balloc.c:15:
   fs/ext4/balloc.c: In function 'ext4_get_group_desc':
>> arch/arm/include/asm/div64.h:60:36: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      60 | #define do_div(n, base) __div64_32(&(n), base)
         |                                    ^~~~
         |                                    |
         |                                    unsigned int *
   fs/ext4/balloc.c:282:11: note: in expansion of macro 'do_div'
     282 |  offset = do_div(group_desc, EXT4_DESC_PER_BLOCK(sb));
         |           ^~~~~~
   arch/arm/include/asm/div64.h:33:45: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'unsigned int *'
      33 | static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
         |                                   ~~~~~~~~~~^
   cc1: some warnings being treated as errors

vim +/__div64_32 +60 arch/arm/include/asm/div64.h

fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  53  
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  54  /*
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  55   * In OABI configurations, some uses of the do_div function
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  56   * cause gcc to run out of registers. To work around that,
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  57   * we can force the use of the out-of-line version for
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  58   * configurations that build a OABI kernel.
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  59   */
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02 @60  #define do_div(n, base) __div64_32(&(n), base)
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  61  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (13770 bytes)