lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Oct 2020 09:10:18 +0800 From: "zhangyi (F)" <yi.zhang@...wei.com> To: <xiakaixu1987@...il.com>, <linux-ext4@...r.kernel.org> CC: <tytso@....edu>, <adilger.kernel@...ger.ca>, Kaixu Xia <kaixuxia@...cent.com> Subject: Re: [PATCH] ext4: remove redundant operation that set bh to NULL On 2020/10/20 19:41, xiakaixu1987@...il.com wrote: > From: Kaixu Xia <kaixuxia@...cent.com> > > The out_fail branch path don't release the bh and the second bh is > valid only in the for statement, so we don't need to set them to NULL. > > Signed-off-by: Kaixu Xia <kaixuxia@...cent.com> Thanks for the patch. It looks good to me. Reviewed-by: zhangyi (F) <yi.zhang@...wei.com> Yi. > --- > fs/ext4/super.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 5308f0d5fb5a..3ebfabc6061a 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -4093,7 +4093,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) > if (IS_ERR(bh)) { > ext4_msg(sb, KERN_ERR, "unable to read superblock"); > ret = PTR_ERR(bh); > - bh = NULL; > goto out_fail; > } > /* > @@ -4721,7 +4720,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) > "can't read group descriptor %d", i); > db_count = i; > ret = PTR_ERR(bh); > - bh = NULL; > goto failed_mount2; > } > rcu_read_lock(); >
Powered by blists - more mailing lists