linux-ext4 - Re: [PATCH] ext4: remove redundant operation that set bh to NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201203141557.GG441757@mit.edu>
Date:   Thu, 3 Dec 2020 09:15:57 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     "zhangyi (F)" <yi.zhang@...wei.com>
Cc:     xiakaixu1987@...il.com, linux-ext4@...r.kernel.org,
        adilger.kernel@...ger.ca, Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] ext4: remove redundant operation that set bh to NULL

On Wed, Oct 21, 2020 at 09:10:18AM +0800, zhangyi (F) wrote:
> On 2020/10/20 19:41, xiakaixu1987@...il.com wrote:
> > From: Kaixu Xia <kaixuxia@...cent.com>
> > 
> > The out_fail branch path don't release the bh and the second bh is
> > valid only in the for statement, so we don't need to set them to NULL.
> > 
> > Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
> 
> Thanks for the patch. It looks good to me.
> Reviewed-by: zhangyi (F) <yi.zhang@...wei.com>

Applied, thanks.

					- Ted