linux-ext4 - Re: [PATCH 5/8] ext4: update ext4_data_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <C06038FE-7970-45A3-8363-F83DEADDC146@dilger.ca>
Date:   Fri, 23 Oct 2020 17:09:16 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Chunguang Xu <brookxu.cn@...il.com>
Cc:     Ted Tso <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 5/8] ext4: update ext4_data_block_valid related comments

On Oct 21, 2020, at 3:15 AM, Chunguang Xu <brookxu.cn@...il.com> wrote:
> 
> From: Chunguang Xu <brookxu@...cent.com>
> 
> Since ext4_data_block_valid() has been renamed to ext4_inode_block_valid(),
> the related comments need to be updated.
> 
> Signed-off-by: Chunguang Xu <brookxu@...cent.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/block_validity.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
> index 37025e3..07e9dc3 100644
> --- a/fs/ext4/block_validity.c
> +++ b/fs/ext4/block_validity.c
> @@ -206,7 +206,7 @@ static void ext4_destroy_system_zone(struct rcu_head *rcu)
>  *
>  * The update of system_blks pointer in this function is protected by
>  * sb->s_umount semaphore. However we have to be careful as we can be
> - * racing with ext4_data_block_valid() calls reading system_blks rbtree
> + * racing with ext4_inode_block_valid() calls reading system_blks rbtree
>  * protected only by RCU. That's why we first build the rbtree and then
>  * swap it in place.
>  */
> @@ -262,7 +262,7 @@ int ext4_setup_system_zone(struct super_block *sb)
> 
> 	/*
> 	 * System blks rbtree complete, announce it once to prevent racing
> -	 * with ext4_data_block_valid() accessing the rbtree at the same
> +	 * with ext4_inode_block_valid() accessing the rbtree at the same
> 	 * time.
> 	 */
> 	rcu_assign_pointer(sbi->s_system_blks, system_blks);
> @@ -282,7 +282,7 @@ int ext4_setup_system_zone(struct super_block *sb)
>  *
>  * The update of system_blks pointer in this function is protected by
>  * sb->s_umount semaphore. However we have to be careful as we can be
> - * racing with ext4_data_block_valid() calls reading system_blks rbtree
> + * racing with ext4_inode_block_valid() calls reading system_blks rbtree
>  * protected only by RCU. So we first clear the system_blks pointer and
>  * then free the rbtree only after RCU grace period expires.
>  */
> --
> 1.8.3.1
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)