linux-ext4 - Re: [PATCH 7/8] ext4: delete invalid code inside ext4_xattr_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <76E661D8-8A67-4588-AD05-64456F51B14D@dilger.ca>
Date:   Fri, 23 Oct 2020 17:10:47 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Chunguang Xu <brookxu.cn@...il.com>
Cc:     Ted Tso <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 7/8] ext4: delete invalid code inside
 ext4_xattr_block_set()

On Oct 21, 2020, at 3:15 AM, Chunguang Xu <brookxu.cn@...il.com> wrote:
> 
> From: Chunguang Xu <brookxu@...cent.com>
> 
> Delete invalid code inside ext4_xattr_block_set().
> 
> Signed-off-by: Chunguang Xu <brookxu@...cent.com>

I would maybe write "inactive code", but seems OK either way

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/xattr.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 6127e94..4e3b1f8 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1927,7 +1927,6 @@ struct ext4_xattr_block_find {
> 	} else {
> 		/* Allocate a buffer where we construct the new block. */
> 		s->base = kzalloc(sb->s_blocksize, GFP_NOFS);
> -		/* assert(header == s->base) */
> 		error = -ENOMEM;
> 		if (s->base == NULL)
> 			goto cleanup;
> --
> 1.8.3.1
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)