lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 16 Nov 2020 11:25:11 +0000
From:   Luca Boccassi <Luca.Boccassi@...rosoft.com>
To:     "ebiggers@...nel.org" <ebiggers@...nel.org>,
        "linux-fscrypt@...r.kernel.org" <linux-fscrypt@...r.kernel.org>
CC:     "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "victorhsieh@...gle.com" <victorhsieh@...gle.com>,
        "linux-f2fs-devel@...ts.sourceforge.net" 
        <linux-f2fs-devel@...ts.sourceforge.net>,
        "Jes.Sorensen@...il.com" <Jes.Sorensen@...il.com>,
        "maco@...roid.com" <maco@...roid.com>,
        "paullawrence@...gle.com" <paullawrence@...gle.com>
Subject: Re: [PATCH 4/4] fs-verity: move structs needed for file signing to
 UAPI header

On Fri, 2020-11-13 at 13:19 -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Although it isn't used directly by the ioctls,
> "struct fsverity_descriptor" is required by userspace programs that need
> to compute fs-verity file digests in a standalone way.  Therefore
> it's also needed to sign files in a standalone way.
> 
> Similarly, "struct fsverity_formatted_digest" (previously called
> "struct fsverity_signed_digest" which was misleading) is also needed to
> sign files if the built-in signature verification is being used.
> 
> Therefore, move these structs to the UAPI header.
> 
> While doing this, try to make it clear that the signature-related fields
> in fsverity_descriptor aren't used in the file digest computation.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  Documentation/filesystems/fsverity.rst |  6 +---
>  fs/verity/fsverity_private.h           | 37 -------------------
>  include/uapi/linux/fsverity.h          | 49 ++++++++++++++++++++++++++
>  3 files changed, 50 insertions(+), 42 deletions(-)

Acked-by: Luca Boccassi <luca.boccassi@...rosoft.com>

-- 
Kind regards,
Luca Boccassi

Download attachment "signature.asc" of type "application/pgp-signature" (485 bytes)

Powered by blists - more mailing lists