linux-ext4 - Re: [PATCH 2/9] f2fs: remove f2fs_dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9522461b-b854-76ac-29c7-160f0f078823@huawei.com>
Date:   Thu, 26 Nov 2020 15:04:55 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Eric Biggers <ebiggers@...nel.org>, <linux-fscrypt@...r.kernel.org>
CC:     <linux-ext4@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-mtd@...ts.infradead.org>, <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 2/9] f2fs: remove f2fs_dir_open()

On 2020/11/25 8:23, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Since encrypted directories can be opened without their encryption key
> being available, and each readdir tries to set up the key, trying to set

readdir -> readdir/lookup?

> up the key in ->open() too isn't really useful.
> 
> Just remove it so that directories don't need an ->open() method
> anymore, and so that we eliminate a use of fscrypt_get_encryption_info()
> (which I'd like to stop exporting to filesystems).
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,