lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <X8bK9l/9N03++CYM@sol.localdomain> Date: Tue, 1 Dec 2020 15:00:06 -0800 From: Eric Biggers <ebiggers@...nel.org> To: Chao Yu <yuchao0@...wei.com> Cc: linux-fscrypt@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-mtd@...ts.infradead.org, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH 2/9] f2fs: remove f2fs_dir_open() On Thu, Nov 26, 2020 at 03:04:55PM +0800, Chao Yu wrote: > On 2020/11/25 8:23, Eric Biggers wrote: > > From: Eric Biggers <ebiggers@...gle.com> > > > > Since encrypted directories can be opened without their encryption key > > being available, and each readdir tries to set up the key, trying to set > > readdir -> readdir/lookup? Yes, ->lookup() tries to set up the key too. It's different because ->lookup() doesn't require that the directory be open. But I suppose that's another reason why setting up the directory's key in ->open() isn't useful. I'll add something about that. - Eric > > > up the key in ->open() too isn't really useful. > > > > Just remove it so that directories don't need an ->open() method > > anymore, and so that we eliminate a use of fscrypt_get_encryption_info() > > (which I'd like to stop exporting to filesystems). > > > > Signed-off-by: Eric Biggers <ebiggers@...gle.com> > > Reviewed-by: Chao Yu <yuchao0@...wei.com> > > Thanks,
Powered by blists - more mailing lists