linux-ext4 - Re: [PATCH] ext4: remove the unused EXT4_CURRENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201210161806.GB31725@quack2.suse.cz>
Date:   Thu, 10 Dec 2020 17:18:06 +0100
From:   Jan Kara <jack@...e.cz>
To:     xiakaixu1987@...il.com
Cc:     linux-ext4@...r.kernel.org, tytso@....edu,
        adilger.kernel@...ger.ca, Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] ext4: remove the unused EXT4_CURRENT_REV macro

On Thu 12-11-20 14:56:42, xiakaixu1987@...il.com wrote:
> From: Kaixu Xia <kaixuxia@...cent.com>
> 
> There are no callers of the EXT4_CURRENT_REV macro, so remove it.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>

I guess this has fallen through the cracks? The cleanup looks good to me.
You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/ext4.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index bf9429484462..cf1c01139f26 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1858,7 +1858,6 @@ static inline bool ext4_verity_in_progress(struct inode *inode)
>  #define EXT4_GOOD_OLD_REV	0	/* The good old (original) format */
>  #define EXT4_DYNAMIC_REV	1	/* V2 format w/ dynamic inode sizes */
>  
> -#define EXT4_CURRENT_REV	EXT4_GOOD_OLD_REV
>  #define EXT4_MAX_SUPP_REV	EXT4_DYNAMIC_REV
>  
>  #define EXT4_GOOD_OLD_INODE_SIZE 128
> -- 
> 2.20.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR