lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Dec 2020 17:04:19 +0100 From: Jan Kara <jack@...e.cz> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Theodore Ts'o <tytso@....edu>, Harshad Shirwadkar <harshadshirwadkar@...il.com>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] ext4: Fix an IS_ERR() vs NULL check On Fri 23-10-20 14:22:32, Dan Carpenter wrote: > The ext4_find_extent() function never returns NULL, it returns error > pointers. > > Fixes: 44059e503b03 ("ext4: fast commit recovery path") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> I think this fix has fallen through the cracks? It looks good to me so feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/extents.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 6b33b9c86b00..a19d0e3a4126 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -5820,8 +5820,8 @@ int ext4_ext_replay_update_ex(struct inode *inode, ext4_lblk_t start, > int ret; > > path = ext4_find_extent(inode, start, NULL, 0); > - if (!path) > - return -EINVAL; > + if (IS_ERR(path)) > + return PTR_ERR(path); > ex = path[path->p_depth].p_ext; > if (!ex) { > ret = -EFSCORRUPTED; > -- > 2.28.0 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists