linux-ext4 - Re: [PATCH] ext4: Fix an IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201213162525.GA835709@mit.edu>
Date:   Sun, 13 Dec 2020 11:25:25 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Harshad Shirwadkar <harshadshirwadkar@...il.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix an IS_ERR() vs NULL check

On Thu, Dec 10, 2020 at 05:04:19PM +0100, Jan Kara wrote:
> On Fri 23-10-20 14:22:32, Dan Carpenter wrote:
> > The ext4_find_extent() function never returns NULL, it returns error
> > pointers.
> > 
> > Fixes: 44059e503b03 ("ext4: fast commit recovery path")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> I think this fix has fallen through the cracks? It looks good to me so feel
> free to add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

This had indeed slipped through the cracks.  Thanks for pointing it
out; I've applied it.

					- Ted