linux-ext4 - Re: [PATCH 3/8] ext4: Protect superblock modifications with a buffer lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X9t/rpL3HQb4+ecl@mit.edu>
Date:   Thu, 17 Dec 2020 10:56:30 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org,
        harshad shirwadkar <harshadshirwadkar@...il.com>
Subject: Re: [PATCH 3/8] ext4: Protect superblock modifications with a buffer
 lock

On Wed, Dec 16, 2020 at 11:18:39AM +0100, Jan Kara wrote:
> Protect all superblock modifications (including checksum computation)
> with a superblock buffer lock. That way we are sure computed checksum
> matches current superblock contents (a mismatch could cause checksum
> failures in nojournal mode or if an unjournalled superblock update races
> with a journalled one). Also we avoid modifying superblock contents
> while it is being written out (which can cause DIF/DIX failures if we
> are running in nojournal mode).
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted