linux-ext4 - Re: [PATCH 4/8] ext4: Save error info to sb through journal if available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X9uALkz58AUn2TAY@mit.edu>
Date:   Thu, 17 Dec 2020 10:58:38 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org,
        harshad shirwadkar <harshadshirwadkar@...il.com>
Subject: Re: [PATCH 4/8] ext4: Save error info to sb through journal if
 available

On Wed, Dec 16, 2020 at 11:18:40AM +0100, Jan Kara wrote:
> If journalling is still working at the moment we get to writing error
> information to the superblock we cannot write directly to the superblock
> as such write could race with journalled update of the superblock and
> cause journal checksum failures, writing inconsistent information to the
> journal or other problems. We cannot journal the superblock directly
> from the error handling functions as we are running in uncertain context
> and could deadlock so just punt journalled superblock update to a
> workqueue.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted