lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Apr 2021 15:03:30 +0800 From: Shaokun Zhang <zhangshaokun@...ilicon.com> To: <linux-ext4@...r.kernel.org>, <linux-kernel@...r.kernel.org> CC: Yang Guo <guoyang2@...wei.com>, Theodore Ts'o <tytso@....edu>, "Andreas Dilger" <adilger.kernel@...ger.ca>, Shaokun Zhang <zhangshaokun@...ilicon.com> Subject: [PATCH] ext4: Delete redundant uptodate check for buffer From: Yang Guo <guoyang2@...wei.com> The buffer uptodate state has been checked in function set_buffer_uptodate, there is no need use buffer_uptodate before calling set_buffer_uptodate and delete it. Cc: "Theodore Ts'o" <tytso@....edu> Cc: Andreas Dilger <adilger.kernel@...ger.ca> Signed-off-by: Yang Guo <guoyang2@...wei.com> Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com> --- fs/ext4/inode.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0948a43f1b3d..32fa3ad38797 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1066,8 +1066,7 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len, block_end = block_start + blocksize; if (block_end <= from || block_start >= to) { if (PageUptodate(page)) { - if (!buffer_uptodate(bh)) - set_buffer_uptodate(bh); + set_buffer_uptodate(bh); } continue; } @@ -1092,8 +1091,7 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len, } } if (PageUptodate(page)) { - if (!buffer_uptodate(bh)) - set_buffer_uptodate(bh); + set_buffer_uptodate(bh); continue; } if (!buffer_uptodate(bh) && !buffer_delay(bh) && -- 2.7.4
Powered by blists - more mailing lists