linux-ext4 - Re: [PATCH] ext4: Delete redundant uptodate check for buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210401112001.tjwjfrno4ygwwzh2@riteshh-domain>
Date:   Thu, 1 Apr 2021 16:50:01 +0530
From:   Ritesh Harjani <ritesh.list@...il.com>
To:     Shaokun Zhang <zhangshaokun@...ilicon.com>
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yang Guo <guoyang2@...wei.com>, Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Ritesh Harjani <ritesh.list@...il.com>
Subject: Re: [PATCH] ext4: Delete redundant uptodate check for buffer

On 21/04/01 03:03PM, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@...wei.com>
>
> The buffer uptodate state has been checked in function set_buffer_uptodate,
> there is no need use buffer_uptodate before calling set_buffer_uptodate and
> delete it.
>
> Cc: "Theodore Ts'o" <tytso@....edu>
> Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> Signed-off-by: Yang Guo <guoyang2@...wei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com>
> ---
>  fs/ext4/inode.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Thanks for the patch. Changes looks good and trivial.

Feel free to add -
Reviewed-by: Ritesh Harjani <ritesh.list@...il.com>