linux-ext4 - Re: [PATCH] ext4: Fix ext4_error_err save negative errno into superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7103B623-9FD2-4BD2-8A44-8DBE38DFE291@dilger.ca>
Date:   Thu, 1 Apr 2021 19:11:57 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Ye Bin <yebin10@...wei.com>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liu Zhi Qiang <liuzhiqiang26@...wei.com>
Subject: Re: [PATCH] ext4: Fix ext4_error_err save negative errno into
 superblock

On Apr 1, 2021, at 1:22 AM, Ye Bin <yebin10@...wei.com> wrote:
> 
> As read_mmp_block return 1 when failed, so just pass retval to
> save_error_info.

Thank you for submitting this patch, but it should not be accepted.

The commit message is confusing, since the code being changed relates
to retval from write_mmp_block().  That currently returns 1, but
only until your next patch is applied.

I think it is better to fix write_mmp_block() as in your next patch
to return a negative value to be more consistent with other code.

Cheers, Andreas

> Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and
> drop ext4_set_errno()")
> Reported-by: Liu Zhi Qiang <liuzhiqiang26@...wei.com>
> Signed-off-by: Ye Bin <yebin10@...wei.com>
> ---
> fs/ext4/mmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 795c3ff2907c..bb8353e25841 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -171,7 +171,7 @@ static int kmmpd(void *data)
> 		 */
> 		if (retval) {
> 			if ((failed_writes % 60) == 0) {
> -				ext4_error_err(sb, -retval,
> +				ext4_error_err(sb, retval,
> 					       "Error writing to MMP block");
> 			}
> 			failed_writes++;
> --
> 2.25.4
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)