linux-ext4 - Re: [PATCH v2] ext4: Fix ext4_error_err save negative errno into superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <FC1C6625-2E89-4547-B2E4-2D992181309D@dilger.ca>
Date:   Thu, 1 Apr 2021 19:21:58 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Ye Bin <yebin10@...wei.com>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liu Zhi Qiang <liuzhiqiang26@...wei.com>
Subject: Re: [PATCH v2] ext4: Fix ext4_error_err save negative errno into
 superblock

On Apr 1, 2021, at 1:40 AM, Ye Bin <yebin10@...wei.com> wrote:
> 
> As read_mmp_block return 1 when failed. read_mmp_block return -EIO when buffer
> isn't uptodate.

Thank you for this second patch.  Unfortunately, the commit message
is still confusing/incorrect because it references read_mmp_block()
in the first usage but is actually changing write_mmp_block().

With that change you could add a Reviewed-by label from me.

Cheers, Andreas

> Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and
> drop ext4_set_errno()")
> Reported-by: Liu Zhi Qiang <liuzhiqiang26@...wei.com>
> Signed-off-by: Ye Bin <yebin10@...wei.com>
> ---
> fs/ext4/mmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 795c3ff2907c..68fbeedd627b 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -56,7 +56,7 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
> 	wait_on_buffer(bh);
> 	sb_end_write(sb);
> 	if (unlikely(!buffer_uptodate(bh)))
> -		return 1;
> +		return -EIO;
> 
> 	return 0;
> }
> --
> 2.25.4
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)