lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 May 2021 10:16:45 +0800 From: Wu Guanghao <wuguanghao3@...wei.com> To: Благодаренко Артём <artem.blagodarenko@...il.com> CC: <linux-ext4@...r.kernel.org>, <liuzhiqiang26@...wei.com>, <linfeilong@...wei.com> Subject: Re: [PATCH 03/12] zap_sector: fix memory leak Thank you for your comments, I will modify it in the v2 version. Best regards Wu Guanghao 在 2021/5/24 22:40, Благодаренко Артём 写道: > Hello Wu, > > Thank you for the fixes. > > It looks like free and return operators should be placed in {} block. > > { > free(buf); > return; > } > > Now function returns any time block is read successfully. > > Also, this patch can not be applied cleanly to the master HEAD because of wrong offsets. Please rebase. > > Best regards, > Artem Blagodarenko. > >> On 24 May 2021, at 14:20, Wu Guanghao <wuguanghao3@...wei.com> wrote: >> >> In zap_sector(), need free buf before return, >> otherwise it will cause memory leak. >> >> Signed-off-by: Wu Guanghao <wuguanghao3@...wei.com> >> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com> >> Reviewed-by: Wu Bo <wubo40@...wei.com> >> --- >> misc/mke2fs.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/misc/mke2fs.c b/misc/mke2fs.c >> index afbcf486..94f81da9 100644 >> --- a/misc/mke2fs.c >> +++ b/misc/mke2fs.c >> @@ -586,6 +586,7 @@ static void zap_sector(ext2_filsys fs, int sect, int nsect) >> magic = (unsigned int *) (buf + BSD_LABEL_OFFSET); >> if ((*magic == BSD_DISKMAGIC) || >> (*magic == BSD_MAGICDISK)) >> + free(buf); >> return; >> } >> } >> -- > > . >
Powered by blists - more mailing lists