lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 May 2021 10:32:24 +0800 From: Wu Guanghao <wuguanghao3@...wei.com> To: <linux-ext4@...r.kernel.org> CC: <liuzhiqiang26@...wei.com>, <linfeilong@...wei.com> Subject: Re: [PATCH 07/12] argv_parse: check return value of malloc in argv_parse() There is a problem with this patch. "argv" is spelled as "arcv". This problem will be resolved in the v2 version. 在 2021/5/24 19:23, Wu Guanghao 写道: > In argv_parse(), return value of malloc should be checked > whether it is NULL, otherwise, it may cause a segfault error. > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com> > Signed-off-by: Wu Guanghao <wuguanghao3@...wei.com> > --- > lib/support/argv_parse.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/support/argv_parse.c b/lib/support/argv_parse.c > index d22f6344..1ef9c014 100644 > --- a/lib/support/argv_parse.c > +++ b/lib/support/argv_parse.c > @@ -116,6 +116,8 @@ int argv_parse(char *in_buf, int *ret_argc, char ***ret_argv) > if (argv == 0) { > argv = malloc(sizeof(char *)); > free(buf); > + if (!arcv) > + return -1; > } > argv[argc] = 0; > if (ret_argc) >
Powered by blists - more mailing lists