lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210630084555.GH1983@kadam> Date: Wed, 30 Jun 2021 11:45:55 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Amir Goldstein <amir73il@...il.com> Cc: kbuild@...ts.01.org, Gabriel Krisman Bertazi <krisman@...labora.com>, kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org, "Darrick J. Wong" <djwong@...nel.org>, Theodore Tso <tytso@....edu>, Dave Chinner <david@...morbit.com>, Jan Kara <jack@...e.com>, David Howells <dhowells@...hat.com>, Khazhismel Kumykov <khazhy@...gle.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Ext4 <linux-ext4@...r.kernel.org>, kernel@...labora.com Subject: Re: [PATCH v3 07/15] fsnotify: pass arguments of fsnotify() in struct fsnotify_event_info On Wed, Jun 30, 2021 at 11:35:32AM +0300, Amir Goldstein wrote: > > Do you have feeling of dejavu? ;-) > https://lore.kernel.org/linux-fsdevel/20200730192537.GB13525@quack2.suse.cz/ That was a year ago. I have trouble remembering emails I sent yesterday. > > We've been through this. > Maybe you silenced the smach warning on fsnotify() and the rename to > __fsnotifty() > caused this warning to refloat? Yes. Renaming the function will make it show up as a new warning. Also this is an email from the kbuild-bot and last years email was from me, so it's a different tool and a different record of sent messages. (IMO, you should really just remove the bogus NULL checks because everyone looking at the warning will think the code is buggy). regards, dan carpenter
Powered by blists - more mailing lists