lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 30 Jun 2021 12:32:25 +0300
From:   Amir Goldstein <>
To:     Dan Carpenter <>
        Gabriel Krisman Bertazi <>,
        kbuild test robot <>,,
        "Darrick J. Wong" <>,
        Theodore Tso <>,
        Dave Chinner <>, Jan Kara <>,
        David Howells <>,
        Khazhismel Kumykov <>,
        linux-fsdevel <>,
        Ext4 <>,
Subject: Re: [PATCH v3 07/15] fsnotify: pass arguments of fsnotify() in struct fsnotify_event_info

On Wed, Jun 30, 2021 at 11:46 AM Dan Carpenter <> wrote:
> On Wed, Jun 30, 2021 at 11:35:32AM +0300, Amir Goldstein wrote:
> >
> > Do you have feeling of dejavu? ;-)
> >
> That was a year ago.  I have trouble remembering emails I sent
> yesterday.
> >
> > We've been through this.
> > Maybe you silenced the smach warning on fsnotify() and the rename to
> > __fsnotifty()
> > caused this warning to refloat?
> Yes.  Renaming the function will make it show up as a new warning.  Also
> this is an email from the kbuild-bot and last years email was from me,
> so it's a different tool and a different record of sent messages.
> (IMO, you should really just remove the bogus NULL checks because
> everyone looking at the warning will think the code is buggy).

I think the warning is really incorrect.
Why does it presume that event_info->dir is non-NULL?
Did smach check all the callers to fsnotify() or something?
What about future callers that will pass NULL, just like this one:

Please fix the tool.


Powered by blists - more mailing lists