lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAOQ4uxgc8dDtJ1f0YSk0fDmdnuU3-kp8cONfuZ5P+7fzvBtZzA@mail.gmail.com> Date: Wed, 30 Jun 2021 12:34:17 +0300 From: Amir Goldstein <amir73il@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: kbuild@...ts.01.org, Gabriel Krisman Bertazi <krisman@...labora.com>, kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org, "Darrick J. Wong" <djwong@...nel.org>, Theodore Tso <tytso@....edu>, Dave Chinner <david@...morbit.com>, Jan Kara <jack@...e.com>, David Howells <dhowells@...hat.com>, Khazhismel Kumykov <khazhy@...gle.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Ext4 <linux-ext4@...r.kernel.org>, kernel@...labora.com Subject: Re: [PATCH v3 07/15] fsnotify: pass arguments of fsnotify() in struct fsnotify_event_info On Wed, Jun 30, 2021 at 12:32 PM Amir Goldstein <amir73il@...il.com> wrote: > > On Wed, Jun 30, 2021 at 11:46 AM Dan Carpenter <dan.carpenter@...cle.com> wrote: > > > > On Wed, Jun 30, 2021 at 11:35:32AM +0300, Amir Goldstein wrote: > > > > > > Do you have feeling of dejavu? ;-) > > > https://lore.kernel.org/linux-fsdevel/20200730192537.GB13525@quack2.suse.cz/ > > > > That was a year ago. I have trouble remembering emails I sent > > yesterday. > > > > > > > > We've been through this. > > > Maybe you silenced the smach warning on fsnotify() and the rename to > > > __fsnotifty() > > > caused this warning to refloat? > > > > Yes. Renaming the function will make it show up as a new warning. Also > > this is an email from the kbuild-bot and last years email was from me, > > so it's a different tool and a different record of sent messages. > > > > (IMO, you should really just remove the bogus NULL checks because > > everyone looking at the warning will think the code is buggy). > > > > I think the warning is really incorrect. > Why does it presume that event_info->dir is non-NULL? > Did smach check all the callers to fsnotify() or something? > What about future callers that will pass NULL, just like this one: > > https://lore.kernel.org/linux-fsdevel/20210629191035.681913-12-krisman@collabora.com/ > FWIW, the caller of this new helper passes NULL as inode: https://lore.kernel.org/linux-fsdevel/20210629191035.681913-14-krisman@collabora.com/ Thanks, Amir.
Powered by blists - more mailing lists