lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210630112153.GA27701@quack2.suse.cz> Date: Wed, 30 Jun 2021 13:21:53 +0200 From: Jan Kara <jack@...e.cz> To: Zhang Yi <yi.zhang@...wei.com> Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, yukuai3@...wei.com Subject: Re: [PATCH] jbd2: fix jbd2_journal_[un]register_shrinker undefined error On Wed 30-06-21 16:36:38, Zhang Yi wrote: > Export jbd2_journal_unregister_shrinker() and > jbd2_journal_register_shrinker() to fix below error: > > ERROR: modpost: "jbd2_journal_unregister_shrinker" undefined! > ERROR: modpost: "jbd2_journal_register_shrinker" undefined! > > Fixes: 4ba3fcdde7e3 ("jbd2,ext4: add a shrinker to release checkpointed buffers") > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Yeah, I didn't notice this either. The fix looks good. You can add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/jbd2/journal.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 7c52feb6f753..152880c298ca 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -2122,6 +2122,7 @@ int jbd2_journal_register_shrinker(journal_t *journal) > > return 0; > } > +EXPORT_SYMBOL(jbd2_journal_register_shrinker); > > /** > * jbd2_journal_unregister_shrinker() > @@ -2134,6 +2135,7 @@ void jbd2_journal_unregister_shrinker(journal_t *journal) > percpu_counter_destroy(&journal->j_jh_shrink_count); > unregister_shrinker(&journal->j_shrinker); > } > +EXPORT_SYMBOL(jbd2_journal_unregister_shrinker); > > /** > * jbd2_journal_destroy() - Release a journal_t structure. > -- > 2.31.1 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists