lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 30 Jun 2021 15:51:11 +0300
From:   Amir Goldstein <>
To:     Dan Carpenter <>
        Gabriel Krisman Bertazi <>,
        kbuild test robot <>,,
        "Darrick J. Wong" <>,
        Theodore Tso <>,
        Dave Chinner <>, Jan Kara <>,
        David Howells <>,
        Khazhismel Kumykov <>,
        linux-fsdevel <>,
        Ext4 <>,
Subject: Re: [PATCH v3 07/15] fsnotify: pass arguments of fsnotify() in struct fsnotify_event_info

On Wed, Jun 30, 2021 at 1:49 PM Dan Carpenter <> wrote:
> I think my bug report was not clear...  :/  The code looks like this:
>         sb = inode->i_sb;
>         if (inode) ...
> The NULL check cannot be false because if "inode" is NULL we would have
> already crashed when we dereference it on the line before.
> In this case, based on last years discussion, the "inode" pointer can't
> be NULL.  The debate is only whether the unnecessary NULL checks help
> readability or hurt readability.

Right. Sorry, I forgot.

Anyway, patch 11/15 of the same series changes this code to:

 sb = event_info->sb ?: inode->i_sb;

So inode can and will be NULL coming from the caller of
fsnotify_sb_error(sb, NULL).

I think that should make smach happy?
You can try to run it after patch 11/15 of this series.


Powered by blists - more mailing lists