linux-ext4 - Re: [PATCH 5/5] ext4: Improve scalability of ext4 orphan file handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210812125926.GC14675@quack2.suse.cz>
Date:   Thu, 12 Aug 2021 14:59:26 +0200
From:   Jan Kara <jack@...e.cz>
To:     kernel test robot <lkp@...el.com>
Cc:     Jan Kara <jack@...e.cz>, Ted Tso <tytso@....edu>,
        kbuild-all@...ts.01.org, linux-ext4@...r.kernel.org,
        Lukas Czerner <lczerner@...hat.com>
Subject: Re: [PATCH 5/5] ext4: Improve scalability of ext4 orphan file
 handling

On Thu 12-08-21 02:19:33, kernel test robot wrote:
> Hi Jan,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on ext4/dev]
> [also build test WARNING on ext3/for_next linus/master v5.14-rc5 next-20210811]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> config: parisc-randconfig-s032-20210810 (attached as .config)
> compiler: hppa-linux-gcc (GCC) 10.3.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # apt-get install sparse
>         # sparse version: v0.6.3-348-gf0e6938b-dirty
>         # https://github.com/0day-ci/linux/commit/77029a42c6e037181b218cbf10a93561e664fb9e
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113
>         git checkout 77029a42c6e037181b218cbf10a93561e664fb9e
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash fs/ext4/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
> >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32
> >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32
> >> fs/ext4/orphan.c:76:18: sparse: sparse: cast to restricted __le32
...
>   > 76		} while (cmpxchg(&bdata[j], 0, cpu_to_le32(inode->i_ino)) != 0);

Yeah, I didn't bother to convert 0 to little endian which is tripping up
sparse. I've now added explicit casts of 0 to __le32 so silence the
warning.

								Honza


-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR