linux-ext4 - Re: algorithm for half-md4 used in htree directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWnbjI9Fo0gKmwS5@mit.edu>
Date:   Fri, 15 Oct 2021 15:50:36 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Avi Deitcher <avi@...tcher.net>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: algorithm for half-md4 used in htree directories

Oh, and taking a quick look at your program, here's at least one of
the bugs:

static void calculate(char *name) {
                      ^^^^^^^^^^
...
    __ext4fs_dirhash(name, sizeof(name), &hinfo);
                           ^^^^^^^^^^^^

With apologies to the movie "The Princess Bride"[1]:

    You fell victim to one of the classic blunders!  The most famous
    is to never get involved in a land war in Asia, but only slightly
    less well-known is this: 'taking the size of a C pointer is
    generally not what you had wanted to do'!  :-)

[1] https://www.youtube.com/watch?v=R7TFPQqglb4

    	  	    	       - Ted