lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Oct 2021 15:49:52 +0200 From: Jan Kara <jack@...e.cz> To: Ye Bin <yebin10@...wei.com> Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, jack@...e.cz Subject: Re: [PATCH -next v4 3/3] ext4: simplify read_mmp_block fucntion On Tue 19-10-21 20:39:31, Ye Bin wrote: > This patch is according to Jan Kara's suggestion: > I guess I would just get rid of sb_getblk() in read_mmp_block() and always > expect valid bh passed. The only place that passes NULL bh after this > patch is one case in ext4_multi_mount_protect() and that can call > sb_getblk() on its own. That way we can also simplify read_mmp_block() > prototype to: > > static int read_mmp_block(struct super_block *sb, struct buffer_head *bh); > > Signed-off-by: Ye Bin <yebin10@...wei.com> > Reviewed-by: Jan Kara <jack@...e.cz> ... > @@ -289,7 +279,11 @@ int ext4_multi_mount_protect(struct super_block *sb, > goto failed; > } > > - retval = read_mmp_block(sb, &bh, mmp_block); > + bh = sb_getblk(sb, mmp_block); > + if (bh) ^^^^^^ !bh here, please. Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists