linux-ext4 - Re: [PATCH -next v4 3/3] ext4: simplify read_mmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <616F84B6.4040307@huawei.com>
Date:   Wed, 20 Oct 2021 10:53:42 +0800
From:   yebin <yebin10@...wei.com>
To:     Jan Kara <jack@...e.cz>
CC:     <tytso@....edu>, <adilger.kernel@...ger.ca>,
        <linux-ext4@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next v4 3/3] ext4: simplify read_mmp_block fucntion



On 2021/10/19 21:49, Jan Kara wrote:
> On Tue 19-10-21 20:39:31, Ye Bin wrote:
>> This patch is according to Jan Kara's suggestion:
>> I guess I would just get rid of sb_getblk() in read_mmp_block() and always
>> expect valid bh passed. The only place that passes NULL bh after this
>> patch is one case in ext4_multi_mount_protect() and that can call
>> sb_getblk() on its own. That way we can also simplify read_mmp_block()
>> prototype to:
>>
>> static int read_mmp_block(struct super_block *sb, struct buffer_head *bh);
>>
>> Signed-off-by: Ye Bin <yebin10@...wei.com>
>> Reviewed-by: Jan Kara <jack@...e.cz>
> ...
>
>> @@ -289,7 +279,11 @@ int ext4_multi_mount_protect(struct super_block *sb,
>>   		goto failed;
>>   	}
>>   
>> -	retval = read_mmp_block(sb, &bh, mmp_block);
>> +	bh = sb_getblk(sb, mmp_block);
>> +	if (bh)
> 	^^^^^^
>
> !bh here, please.
Sorry，it's my fault. I will fix it and test  this patch set base on 
linux mainline.
>
> 								Honza
>