linux-ext4 - Re: [LTP] [PATCH v3 3/9] syscalls/fanotify21: Introduce FAN_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYTyWs4UPEL0eqjR@pevik>
Date:   Fri, 5 Nov 2021 09:59:06 +0100
From:   Petr Vorel <pvorel@...e.cz>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     Gabriel Krisman Bertazi <krisman@...labora.com>,
        kernel@...labora.com, Khazhismel Kumykov <khazhy@...gle.com>,
        Matthew Bobrowski <repnop@...gle.com>,
        Jan Kara <jack@...e.com>, Ext4 <linux-ext4@...r.kernel.org>,
        LTP List <ltp@...ts.linux.it>
Subject: Re: [LTP] [PATCH v3 3/9] syscalls/fanotify21: Introduce FAN_FS_ERROR
 test

Hi all,

...
> > +static struct tst_test test = {
> > +       .test = do_test,
> > +       .tcnt = ARRAY_SIZE(testcases),
> > +       .setup = setup,
> > +       .cleanup = cleanup,
> > +       .mount_device = 1,
> > +       .mntpoint = MOUNT_PATH,
> > +       .all_filesystems = 0,

> That's probably redundant and the default value anyway.
> If you want to stress out that this test cannot be run on other filesystems
> maybe add a comment why that is above dev_fs_type.

Yes, good catch. Thanks!

Kind regards,
Petr