lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Dec 2021 15:43:36 +0800 From: zhanchengbin <zhanchengbin1@...wei.com> To: Theodore Ts'o <tytso@....edu> CC: <linux-ext4@...r.kernel.org>, <liuzhiqiang26@...wei.com>, <linfeilong@...wei.com>, <wubo40@...wei.com> Subject: [PATCH v2 6/6] lib/ext2fs: call ext2fs_free_mem() to free &io->name, in exception branch In the exception branch,if we donot call ext2fs_free_mem() to free &io->name, memory leak will occur. Signed-off-by: zhanchengbin <zhanchengbin1@...wei.com> --- lib/ext2fs/test_io.c | 2 ++ lib/ext2fs/undo_io.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/lib/ext2fs/test_io.c b/lib/ext2fs/test_io.c index 480e68fc..6843edbc 100644 --- a/lib/ext2fs/test_io.c +++ b/lib/ext2fs/test_io.c @@ -248,6 +248,8 @@ static errcode_t test_open(const char *name, int flags, io_channel *channel) return 0; cleanup: + if (io && io->name) + ext2fs_free_mem(&io->name); if (io) ext2fs_free_mem(&io); if (data) diff --git a/lib/ext2fs/undo_io.c b/lib/ext2fs/undo_io.c index eb56f53d..0d4915cb 100644 --- a/lib/ext2fs/undo_io.c +++ b/lib/ext2fs/undo_io.c @@ -788,6 +788,8 @@ cleanup: free(data->tdb_file); if (data && data->real) io_channel_close(data->real); + if (io && io->name) + ext2fs_free_mem(&io->name); if (data) ext2fs_free_mem(&data); if (io) -- 2.27.0
Powered by blists - more mailing lists