lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 May 2022 13:14:08 -0400 From: "Theodore Ts'o" <tytso@....edu> To: zhanchengbin <zhanchengbin1@...wei.com> Cc: linux-ext4@...r.kernel.org, liuzhiqiang26@...wei.com, linfeilong@...wei.com, wubo40@...wei.com Subject: Re: [PATCH v2 0/6] solve memory leak and check whether NULL pointer On Fri, Dec 31, 2021 at 03:40:41PM +0800, zhanchengbin wrote: > Solve the memory leak of the abnormal branch and the new null pointer check Applied, but the patches were all white-space damaged so I had to apply them by hand. I also reworded the commit description to be clearer. The one exception is the patch to lib/ss, which had already been fixed commit a282671a0 ("libss: fix possible NULL pointer dereference on allocation failure") in my tree. Cheers, - Ted > Changes from V1: > --------------- > - In the V1 of the patch series, have a bug in patch 1/6, when s->s get > memory successd, s-len is not assigned a value. > > zhanchengbin (6): > e2fsck: set s->len=0 if malloc() fails in alloc_string() > lib/ss: check whether argp is null before accessing it in > ss_execute_command() > lib/support: check whether inump is null before accessing it in > quota_set_sb_inum() > e2fsprogs: call ext2fs_badblocks_list_free() to free list in exception > branch > e2fsck: check whether ldesc is null before accessing it in > end_problem_latch() > lib/ext2fs: call ext2fs_free_mem() to free &io->name in exception > branch > > e2fsck/logfile.c | 2 +- > e2fsck/problem.c | 2 ++ > lib/ext2fs/test_io.c | 2 ++ > lib/ext2fs/undo_io.c | 2 ++ > lib/ss/execute_cmd.c | 2 ++ > lib/support/mkquota.c | 3 ++- > misc/dumpe2fs.c | 1 + > resize/resize2fs.c | 4 ++-- > 8 files changed, 14 insertions(+), 4 deletions(-) > > -- > 2.27.0
Powered by blists - more mailing lists