linux-ext4 - Re: [PATCH] common/rc: set maximum label length for ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220131204625.eimkrccyp4lqit57@work>
Date:   Mon, 31 Jan 2022 21:46:25 +0100
From:   Lukas Czerner <lczerner@...hat.com>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     fstests@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] common/rc: set maximum label length for ext4

On Mon, Jan 31, 2022 at 09:07:00AM -0800, Darrick J. Wong wrote:
> On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote:
> > Set maximum label length for ext4 in _label_get_max() to be able to test
> > online file system label set/get ioctls.
> > 
> > Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> > ---
> >  common/rc | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/common/rc b/common/rc
> > index 8e351f17..50d6d0bd 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -4545,6 +4545,9 @@ _label_get_max()
> >  	f2fs)
> >  		echo 255
> >  		;;
> > +	ext2|ext3|ext4)
> > +		echo 16
> 
> After reviewing the ext4 ondisk format, 16 is the correct value.
> 
> Though I wonder, what actually prevents generic/492 from running on old
> kernels without GETLABEL support?

_require_xfs_io_command "label"

should take care of that. This is why I though it was no problem to get
this change in early.

-Lukas

> 
> Either way this patch is ok, so...
> Reviewed-by: Darrick J. Wong <djwong@...nel.org>
> 
> --D
> 
> > +		;;
> >  	*)
> >  		_notrun "$FSTYP does not define maximum label length"
> >  		;;
> > -- 
> > 2.31.1
> > 
>